Merged
Conversation
…ntle for `uv` (#90) * Remove async code from the Drop handler * feat: More graceful process shutdown to be gentle to uv * chore: Refactor kill_child_process based on @copilot feedback * chore: Only use process_group on unix systems * chore: Only import the nix::* content in Unix land * Update crates/tower-runtime/src/local.rs Co-authored-by: Konstantinos St <kons.ste@gmail.com> --------- Co-authored-by: Konstantinos St <kons.ste@gmail.com>
fix: handle 404s gracefully
Update clients
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a Tower CLI release that updates the version to 0.3.28 and incorporates API changes from OpenAPI version v0.7.10. The release includes user preference management enhancements and process control improvements.
- Addition of changelog subscription preference for users
- Implementation of improved Unix process termination with signal handling
- Updated API client models to reflect latest OpenAPI specification (v0.7.10)
Reviewed Changes
Copilot reviewed 172 out of 174 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump to 0.3.28 |
| Cargo.toml | Version bump and adds nix dependency for Unix signal handling |
| src/tower/tower_api_client/models/user.py | Adds is_subscribed_to_changelog field to User model |
| src/tower/tower_api_client/models/update_user_params.py | Adds changelog subscription option to user update parameters |
| src/tower/tower_api_client/models/app.py | Promotes health_status from optional to required field |
| crates/tower-runtime/src/local.rs | Implements proper Unix process termination with SIGTERM/SIGKILL |
| crates/tower-uv/src/lib.rs | Adds process group configuration for Unix systems |
| crates/tower-cmd/src/output.rs | Adds NOT_FOUND error handling with detailed error output |
| Multiple API model files | Updates OpenAPI version references from v0.7.6 to v0.7.10 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
socksy
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.